Run travis tests for 1.22.0 osx, stable on linux, nightly on osx #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis supports building on osx, but we aren't running the tests in a few configurations, like OSX with rust 1.22.0, native linux on stable, and OSX on nightly. This adds testers for these situations to make sure that bugs like rust-random#720 don't slip into the system again.
|
As an alternative, libc has a nice setup for multi architecture testing in rust-lang/libc#1233. |
dhardy
approved these changes
Feb 4, 2019
| @@ -104,6 +110,9 @@ matrix: | |||
| env: DESCRIPTION="beta Rust release" | |||
|
|
|||
| - rust: nightly | |||
| os: | |||
| - linux | |||
| - osx | |||
There was a problem hiding this comment.
This could cause a problem: it does a doc-upload at the end. Perhaps you can prefix that:
test "$TRAVIS_OS_NAME" = "linux" && travis-cargo --only nightly doc-upload
|
I know @jcjones was having some trouble with OSX that he hadn't raised as an issue yet: mozilla/authenticator-rs#76 |
|
@jonathanKingston or @jcjones please create a new issue about that. I guess I'll make the suggested change myself and merge this manually. |
|
This doesn't appear to include all the expected builds. Any idea why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis supports building on osx, but we aren't running the tests in a few configurations, like OSX with rust 1.22.0, native linux on stable, and OSX on nightly. This adds testers for these situations to make sure that bugs like #720 don't slip into the system again.