Enable std by default in rand_core; adjust CI targets #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using --all and --features together
|
I think yes, it should not break code, right? |
|
Is there a rush to make a release with this? I have not read the thread well, does it stop building on nightly cargo? |
|
No, there's not a rush. The only thing that will break is our CI scripts. But enabling |
Release together with rand 0.5? And do you think it makes sense to already upgrade to serde 1.0.38? serde-rs/serde#1207 (comment) |
|
1.0.38 is a patch-release so users will be upgraded automatically — therefore no reason we shouldn't use it, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using --all and --features together (fix #406)
Can we release rand_core 0.1.1 with this change?