Implement Rand for longer arrays #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! That looks like a clever macro trick, I know of another place that could use it #354 (comment) 😄. I am not against implementing this for more array sizes as you did, and 4096 seems like a very reasonable number of elements to stop. Curious what @dhardy thinks of it though. |
dhardy
approved these changes
Apr 1, 2018
There was a problem hiding this comment.
Looks good to me!
@pitdicker since you have so many PRs open you know better than me which to merge first?
|
I expect one or two will have to rebase... Let's do this one first! |
pitdicker
added a commit
that referenced
this pull request
Apr 4, 2018
Implement Rand for longer arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Rand for [T; N] where N is 2^{6~12}