Skip to content

Benchmark specialized distribution implementations #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

Benchmark specialized distribution implementations #1063

merged 1 commit into from
Nov 2, 2020

Conversation

vks
Copy link
Collaborator

@vks vks commented Oct 27, 2020

As noted in #1062, this demonstrates that Exp1 is slower than Exp, which kind of defeats its purpose.

@vks vks mentioned this pull request Oct 27, 2020
Closed
@dhardy
Copy link
Member

dhardy commented Oct 28, 2020

Presumably the optimiser can remove the addition/multiplation by identity here.

There is still one other potential reason to use Exp1/StandardNormal: to reduce data size within some other sampler instanced many times. This doesn't require explicit documentation, except perhaps pointing out that they are the building blocks.

dhardy
dhardy approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we might as well merge this.

@dhardy dhardy merged commit ce59c9c into rust-random:master Nov 2, 2020
@vks vks deleted the bench_specialized_distr branch November 2, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vks @dhardy