Test Linux fallback paths without use of cfg()s #628
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| //! This test forces the Linux fallback path to be taken. This test must be | ||
| //! run manually and sequentally: | ||
| //! | ||
| //! cargo test --test linux_force_fallback -- --test-threads 1 | ||
| use std::{ | ||
| ffi::c_void, | ||
| fs::{read_dir, DirEntry}, | ||
| sync::atomic::{AtomicBool, Ordering}, | ||
| }; | ||
|
|
||
| use libc::{__errno_location, c_uint, size_t, ssize_t, ENOSYS}; | ||
|
|
||
| static FAKE_GETRANDOM_CALLED: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| // Override libc::getrandom to simulate failure | ||
| #[export_name = "getrandom"] | ||
| pub unsafe extern "C" fn fake_getrandom(_: *mut c_void, _: size_t, _: c_uint) -> ssize_t { | ||
| FAKE_GETRANDOM_CALLED.store(true, Ordering::SeqCst); | ||
|
There was a problem hiding this comment. I think |
||
| unsafe { *__errno_location() = ENOSYS }; | ||
| -1 | ||
| } | ||
|
|
||
| mod common; | ||
|
|
||
| #[test] | ||
| fn fake_getrandom_is_called() { | ||
| assert!(FAKE_GETRANDOM_CALLED.load(Ordering::SeqCst)); | ||
| } | ||
|
|
||
| #[test] | ||
| fn dev_urandom_is_open() { | ||
| fn is_urandom(entry: DirEntry) -> bool { | ||
| let path = entry.path().canonicalize().expect("entry is valid"); | ||
| path.to_str() == Some("/dev/urandom") | ||
| } | ||
| let mut dir = read_dir("/proc/self/fd").expect("/proc/self exists"); | ||
| assert!(dir.any(|path| is_urandom(path.expect("entry exists")))); | ||
|
There was a problem hiding this comment. Why not simply inline the let has_open_urandom = read_dir("/proc/self/fd")
.expect("/proc/self exists")
.any(|dir_entry| {
let path = dir_entry.expect("entry exists").path();
let path = path.canonicalize().expect("entry is valid");
path.to_str() == Some("/dev/urandom")
});
assert!(has_open_urandom); |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| //! This test ensures the Linux fallback path is not taken. As this test will | ||
| //! fail in some Linux configurations, it must be run manually and sequentally: | ||
| //! | ||
| //! cargo test --test linux_no_fallback -- --test-threads 1 | ||
| use std::fs::{read_dir, DirEntry}; | ||
|
|
||
| mod common; | ||
|
|
||
| #[test] | ||
| fn dev_urandom_is_not_open() { | ||
| fn is_urandom(entry: DirEntry) -> bool { | ||
| let path = entry.path().canonicalize().expect("entry is valid"); | ||
| path.to_str() == Some("/dev/urandom") | ||
| } | ||
| let mut dir = read_dir("/proc/self/fd").expect("/proc/self exists"); | ||
| assert!(dir.all(|path| !is_urandom(path.expect("entry exists")))); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that the order of tests is guaranteed?