Skip to content

Feat(): Support static compliation on Linux MUSL #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Feat(): Support static compliation on Linux MUSL #4

wants to merge 1 commit into from

Conversation

dandxy89
Copy link

@dandxy89 dandxy89 commented Aug 1, 2021

Fixes #2

Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch this to a draft until it passes all tests ? It looks like this breaks macos compilation.
Also, can you add a test for musl builds in addition to the existing dylib linux, macos, and windows ?

@dandxy89 dandxy89 marked this pull request as draft August 2, 2021 19:30
@dandxy89 dandxy89 closed this Aug 2, 2021
@lovasoa
Copy link
Collaborator

lovasoa commented Aug 2, 2021

You can leave a pr opened even when there are still things to change :) That makes it more visible to others

@dandxy89
Copy link
Author

dandxy89 commented Aug 2, 2021

I've realised I can run the gitflow task on my fork so will continue on there.

To be honest, I'm close to not continuing with it and continue to use Python for our solvers.

Will give it one good go this week 😒

@dandxy89
Copy link
Author

dandxy89 commented Aug 2, 2021

Can you try building the master branch again?

The MacOS failures don't make sense...

@dandxy89
Copy link
Author

dandxy89 commented Aug 2, 2021

Second question: are you using this, good_lp, library at work?

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 2, 2021

yes we are using at enexflow :)

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 2, 2021

i relaunched the ci, but I don't think the problem comes from it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-compiling from MacOS to x86_64-linux-musl
2 participants