Skip to content

Fix #49 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Jul 18, 2019
Merged

Fix #49 #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e10ca81
Fix #49
maxbla Jun 17, 2019
f38ff9c
Implement @cuviper's suggested change
maxbla Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@ impl<T: Clone + Integer> Ord for Ratio<T> {

// With equal numerators, the denominators can be inversely compared
if self.numer == other.numer {
if T::is_zero(self.numer()) {
Comment thread
maxbla marked this conversation as resolved.
Outdated
return cmp::Ordering::Equal;
}
let ord = self.denom.cmp(&other.denom);
return if self.numer < T::zero() {
ord
Expand Down Expand Up @@ -1446,6 +1449,9 @@ mod test {

assert!(_0 >= _0 && _1 >= _1);
assert!(_1 >= _0 && !(_0 >= _1));

let _0_2: Rational = Ratio::new_raw(0, 2);
assert_eq!(_0, _0_2);
}

#[test]
Expand Down Expand Up @@ -1538,7 +1544,7 @@ mod test {

mod arith {
use super::super::{Ratio, Rational};
use super::{_0, _1, _1_2, _2, _3_2, _NEG1_2, to_big};
use super::{to_big, _0, _1, _1_2, _2, _3_2, _NEG1_2};
Comment thread
cuviper marked this conversation as resolved.
use traits::{CheckedAdd, CheckedDiv, CheckedMul, CheckedSub};

#[test]
Expand Down