Auto-nominate for backport a pull request fixing a regression #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1184:
We should nominate PRs for backport if any of the following are true:
This patch implements point (1) and adds a check when a new PR is opened. The new
backport.rs
handler tries to figure to out if a PR should be nominated for backport.This handler is enabled by adding a new
[backport]
config item. The format allows multiple instances of the config so teams can handle backports as they wish.The workflow that models the decision to add the backport label is:
#123
, with a t-label (ex. "T-compiler")#456
, adds comment "Fixes#123
"3a. checks if PR has the required team labels (reads from
team_labels
), loads the appropriate config3b. checks if issue has a
regression-from-*
label (reads fromneeds_label
)3c. checks the P-label of the regression, discard P-low and P-medium regressions
prioritize
command #456 (reads fromadd_labels
)TODOs
Situations not yet handled where this handler should trigger as well:
This work supersedes #1380 (Important: before merge this commit should be Co-authored1)
r?
Footnotes
Not doing now to avoid spamming the original author with multiple forced git push 🙂 ↩