Skip to content

Fix commands in pull request comments #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joboet
Copy link
Member

@joboet joboet commented Sep 11, 2022

Fixes #1651. Pull request comments are detected by checking the presence of the pull_request field in the issue type. Broke in #1646.

@joboet joboet changed the title fix commands in pull request comments Fix commands in pull request comments Sep 11, 2022
@ehuss
Copy link
Contributor

ehuss commented Sep 11, 2022

Sorry about that. I posted an alternate solution at #1653 that just reverts the change. I think the original behavior is fine, and could potentially add fields to the empty struct in the future.

@joboet joboet closed this Sep 11, 2022
@joboet joboet deleted the pull_request_comment branch February 18, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rustbot ready and @rustbot author erroring out in a few cases
2 participants