Skip to content

Update GitHub issue with renamed Zulip topic link #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update GitHub issue with renamed Zulip topic link #1589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/handlers/major_change.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ pub(super) async fn handle_input(
&event.issue,
zulip_msg,
config.meeting_label.clone(),
cmd == Invocation::NewProposal,
Some(cmd),
)
.await
}
Expand Down Expand Up @@ -204,7 +204,7 @@ pub(super) async fn handle_command(
issue,
zulip_msg,
config.second_label.clone(),
false,
None,
)
.await
}
Expand All @@ -215,7 +215,7 @@ async fn handle(
issue: &Issue,
zulip_msg: String,
label_to_add: String,
new_proposal: bool,
cmd: Option<Invocation>,
) -> anyhow::Result<()> {
let github_req = issue.add_labels(&ctx.github, vec![Label { name: label_to_add }]);

Expand All @@ -230,19 +230,31 @@ async fn handle(
content: &zulip_msg,
};

if new_proposal {
if matches!(cmd, Some(Invocation::NewProposal | Invocation::Rename { .. })) {
let topic_url = zulip_req.url();
let comment = format!(
"This issue is not meant to be used for technical discussion. \
There is a Zulip [stream] for that. Use this issue to leave \
procedural comments, such as volunteering to review, indicating that you \
second the proposal (or third, etc), or raising a concern that you would \
like to be addressed. \
\n\n{} \
\n\n[stream]: {}",
config.open_extra_text.as_deref().unwrap_or_default(),
topic_url
);
let comment = match cmd {
Some(Invocation::NewProposal) =>
format!(
"This issue is not meant to be used for technical discussion. \
There is a Zulip [stream] for that. Use this issue to leave \
procedural comments, such as volunteering to review, indicating that you \
second the proposal (or third, etc), or raising a concern that you would \
like to be addressed. \
\n\n{} \
\n\n[stream]: {}",
config.open_extra_text.as_deref().unwrap_or_default(),
topic_url
),
Some(Invocation::Rename { .. }) =>
format!(
"This issue has been renamed, please see the renamed Zulip [stream] for technical discussion. \
\n\n{} \
\n\n[stream]: {}",
config.open_extra_text.as_deref().unwrap_or_default(),
topic_url
),
_ => unreachable!(),
};
issue
.post_comment(&ctx.github, &comment)
.await
Expand Down