Skip to content

Fix compilation with --cfg doc #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Thomasdezeeuw
Copy link
Collaborator

Fixes #383

Does this fix your issue @fpoli?

@fpoli
Copy link

fpoli commented Feb 6, 2023

Yes, thank you. With this revision cargo doc works fine. What I used to test is:

mkdir new-test-crate
cd new-test-crate
cargo init
cargo add --git https://github.com/rust-lang/socket2.git --rev 7b1e1ad841ffdb754ce534dc817c749d8211cc1d
RUSTDOCFLAGS="--generate-link-to-definition -Zunstable-options" cargo +nightly doc

Without the --rev 7b1e1ad841ffdb754ce534dc817c749d8211cc1d the last command fails, as reported in #383.

@Thomasdezeeuw Thomasdezeeuw merged commit d616440 into rust-lang:master Feb 6, 2023
@Thomasdezeeuw Thomasdezeeuw deleted the fix-cfg-doc branch February 6, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error when building with --cfg doc
3 participants