Skip to content

Conversation

@marcoieni
Copy link
Member

Generated with AI starting from the docs.rs nginx config. Didn't review yet. But terraform plan works

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after thinking about it:

It seems like the AWS WAF is running before the cache, so the rate limit rules would apply before too.

Right now, we only check rate limits in the backend, so only uncached requests.

Seeing the difference from the stats (average of 100k rpm on cloudfront, 30k on the backend), at the very least we have to adapt the rate limit accordingly.

But:
The only reason for the rate limit (for me) is protecting the backend. Cached requests can go as high as they want.

So I wonder if we should choose another approach generally, leaving cached requests open, and only rate limiting the origin requests.

Would we have an ALB anyways? Then we could use a regional WAF in front of it?

Even for malicious cases I mostly see a problem when these requests hit the origin, not before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants