refactor(cli/self-update)!: reorganize InstallOpts methods#4950
Draft
rami3l wants to merge 6 commits into
Draft
Conversation
rami3l
commented
Jul 10, 2026
|
|
||
| #[cfg(not(windows))] | ||
| macro_rules! post_install_msg_unix { | ||
| () => { |
Member
Author
There was a problem hiding this comment.
Rust macros follow the buttom-up order so it contradicts with our top-down style guide. Should I move those macros up, or move the renamed method down to its original position?
Member
Author
There was a problem hiding this comment.
Finally I decided to move those messages templates in a new file to minimize the diff.
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
5 times, most recently
from
cc981f1 to
c85a63c
Compare
This comment has been minimized.
This comment has been minimized.
…llOpts::prepare()`
…Opts::install_rust()`
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
c85a63c to
de49ea3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4947 (comment) and #4947 (comment).