Make all utils functions and structs crate-private and cleanup unused functions

[0xPoe]

part of #2730
Because we use some methods in our tests, we need to set it to pub.

[0xPoe]

@kinnison @rbtcollins Could you please take a look? Thanks!

[kinnison]

For the most part I think this is fine - one query, and a quick check from @rbtcollins before this cleanup can go in.

I particularly like that you found what looks like some dead code.

[kinnison]

Looks plausible to me. @rbtcollins are you okay for this to merge?

[0xPoe]

Conflict resolved, @rbtcollins Could you please take a look?

[kinnison]

Please don't merge into your branch, instead rebase onto master. If you need help with that, I can provide it.

[0xPoe]

Please don't merge into your branch, instead rebase onto master. If you need help with that, I can provide it.

Rebased!

[rbtcollins]

I think we need to introduce

#![deny(unreachable_pub)]

To all of our global lints - demo here, try turning it off and on

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=dd28683bfd53acd9b2d3bdc3c92db32e

[0xPoe]

I think we need to introduce

#![deny(unreachable_pub)]

To all of our global lints - demo here, try turning it off and on

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=dd28683bfd53acd9b2d3bdc3c92db32e

@rbtcollins I agree that we should introduce that lint, but should I open it after my current cleanup is done? Right now we have a few more modules of code that need to be modified. If we open it now, there will be a lot of code that needs to be changed that will be warned. Do you think it is acceptable for us to open it at the end? Because the cli module has a lot of code that needs to be changed and I will change it in my next PR.

[0xPoe]

Added a to-do item to the issue.

[rbtcollins]

I had another question on CommandError :)..

Re the lint: I think the lint is part of this bug; it doesn't have to be part of this PR - so it can certainly come in as another patch if it has a lot of dead code it picks up.

Oh - but heres an idea: you could be building the modules you touch with it, even if you don't commit the lint, you commit the results of the cleanup of the lint to the modules so each module is only touched once.

[0xPoe]

I had another question on CommandError :)..

Is this it? #2787 (comment) I should have replied to you?

Oh - but heres an idea: you could be building the modules you touch with it, even if you don't commit the lint, you commit the results of the cleanup of the lint to the modules so each module is only touched once.

Good idea, just tried it in the utils mod and no warnings were reported.

[rbtcollins]

please squash the two commits together, then I think we merge this

[0xPoe]

please squash the two commits together, then I think we merge this

squashed! Thanks again for your review!