Make all diskio functions and structs crate-private #2753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @rbtcollins @kinnison Could you please take a look? |
0xPoe
force-pushed
the
rustin-patch-cleanup-diskio
branch
2 times, most recently
from
ef69eed to
ec202e0
Compare
kinnison
approved these changes
May 7, 2021
|
While this looks good, we'll hold off merging until we've sorted the slab allocator stuff. |
|
This now needs rebasing |
Make some fields private
0xPoe
force-pushed
the
rustin-patch-cleanup-diskio
branch
from
ec202e0 to
ca67287
Compare
Resolved. |
kinnison
approved these changes
May 11, 2021
There was a problem hiding this comment.
I think this is okay. @rbtcollins if you have no objections, I think this can merge.
rbtcollins
reviewed
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2730