Fix UB in 128 bit cttz/ctlz intrinsics #672
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604.
This PR changes a few things.
First of all, it enables UB checks for tests in debug mode: This should allow us to catch any regressions.
Second, I extracted the common implementation of the "safe"
ctlz
/cttz
intrinsics into a separate function.This makes handling the 128 bit edge case a bit easier, and allows us to use those intrinsics.
The third change modifies the 128 bit
ctlz
/cttz
emulation to use the "safe" version of the 64 bit intrinsic, instead of calling the GCC built-in directly.Effectively, this turns a piece of IR like this:
Into a piece of code like this:
This solution is not the prettiest(maybe a few less branches could be used?), but it is UB-free, and relatively easy to implement.