-
Notifications
You must be signed in to change notification settings - Fork 108
Add initial f16
/f128
support
#1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
LGTM for the non cranelift-specific parts, LLVM also does promote/demote for f16 powi and fmod. |
Is Cranelift ABI compatible with LLVM for f16 and f128 across all targets Cranelift supports? |
By architecture/platform:
Summary: All Cranelift |
Update: basic load/store/bitcast support is now available for all 4 architectures. Combined with the |
As a note, once the above lowering to rustc_codegen_cranelift/src/lib.rs Lines 200 to 208 in dfe7636
|
This PR adds basic initial support for
f16
andf128
. While this allows simple programs (e.g.dbg!(1.0_f16)
) to compile on architectures where Cranelift has basic support forf16
/f128
values (currently x86-64 and AArch64),rustc_codegen_cranelift
still can't compilecompiler_builtins
withoutno-f16-f128
due to missing support incranelift_frontend
(fixed by bytecodealliance/wasmtime#10631) andcompiler_builtins
requiring math support.cc @tgross35