Skip to content

Add Cargo, Webrender, Ripgrep #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2018
Merged

Add Cargo, Webrender, Ripgrep #233

merged 3 commits into from
May 24, 2018

Conversation

Mark-Simulacrum
Copy link
Member

Incrementally adding a smaller portion of the benchmarks listed in #192 to see
if we can afford to do this on current hardware.

cc @michaelwoerister

@Mark-Simulacrum
Copy link
Member Author

We should also find some way long-term to do this without ~200,000 line additions, but that's a different problem we can solve later.

@Mark-Simulacrum Mark-Simulacrum merged commit bbce846 into rust-lang:master May 24, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the add-benchmarks branch May 24, 2018 02:35
@nnethercote
Copy link
Contributor

When I try to benchmark or profile cargo locally I get this error:

stderr=error: extra arguments to `rustc` can only be passed to one target, consider filtering
the package by passing e.g. `--lib` or `--bin NAME` to specify a single target

A normal cargo build in the cargo directory works, though.

@michaelwoerister
Copy link
Member

Thanks @Mark-Simulacrum!

@nnethercote
Copy link
Contributor

I updated my rustc and the cargo benchmark is now working.

@nnethercote
Copy link
Contributor

Looking at http://perf.rust-lang.org, ripgrep is showing up on both the graphs page and the compare page, but cargo and webrender are not.

@Mark-Simulacrum
Copy link
Member Author

I think they should start showing up soon -- I just pushed a fix for webrender (and deployed), Cargo was also somewhat recently fixed. I'll try to keep an eye on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants