Soften the language of regression comments on merged PRs #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @workingjubilee please remember to get to this tomorrow ok? |
|
damn I can't notify myself. |
nnethercote
reviewed
Sep 2, 2024
nnethercote
approved these changes
Sep 2, 2024
|
I've also discussed this topic with contributors at rustconf, and some piece of feedback I received was that the noise in the system and false positives that can happen, may also warrant a reword of the very-confident "This is a highly reliable metric" message. This has caused people to investigate regressions that weren't there, but didn't know about these annoying occurrences. This PR already mentions the noise so we may just need to soften the metrics descriptions and fix this at the same time. |
Kobzol
force-pushed
the
regression-pr-comment-change-text
branch
from
21490de to
13a4495
Compare
|
Tried to reword in 13a4495. |
|
lgtm! |
lqd
approved these changes
Oct 4, 2024
workingjubilee
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been noted several times on Zulip that the current message on regressions is perhaps too aggressive, and does not help contributors enough. It also does not mention the possibility that the found regression is just a false alarm, which does sadly happen quite often.
This PR is an attempt to improve upon that. Let the bike-shedding commence!