Rollup of 6 pull requests #98691
Merged
Rollup of 6 pull requests #98691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… async fn desugaring, make that explicit
This fixes the long-standing FIXME there and makes the code easier to understand. The reference to modules in both the old and new names seems potentially wrong since I believe it applies to all items.
not sure if the issue should actually get closed though, hm r? @compiler-errors
Make TAIT behave exactly like RPIT fixes rust-lang#96552 This makes type-alias-impl-trait behave like return-position-impl-trait. Unfortunately it also causes some cases to stop compiling due to "needing type annotations" and makes panicking cause fallback for the hidden type to `()`. All of these are addressable, but we should probably address them for RPIT and TAIT together r? ``@lcnr``
…type-blanket-impl, r=GuillaumeGomez rustdoc-json: Make default value of blanket impl assoc types work Closes rust-lang#98658 r? ``@GuillaumeGomez`` ``@rustbot`` labels +A-rustdoc-json
…-errors add tests for ICE 94432 Fixes rust-lang#94432
…iler-errors add test for ice 68875 Fixes rust-lang#68875
Replace `sort_modules_alphabetically` boolean with enum This fixes the long-standing FIXME there and makes the code easier to understand. The reference to modules in both the old and new names seems potentially wrong since I believe it applies to all items. r? ``@GuillaumeGomez``
…-errors add test for 47814 not sure if the issue should actually get closed though, hm r? ``@compiler-errors``
rustbot
added
T-compiler
|
@bors r+ rollup=never p=6 |
|
📌 Commit 943c6c7 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5d3c6d6): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
sort_modules_alphabeticallyboolean with enum #98685 (Replacesort_modules_alphabeticallyboolean with enum)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup