Skip to content

change mir::Constant in mir dumps #94209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

change mir::Constant in mir dumps #94209

merged 1 commit into from
Feb 22, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 21, 2022

this removes duplicate information and avoids printing the stable_crate_id in mir dumps which broke CI in #94059

r? @oli-obk cc @b-naber

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 21, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 21, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

📌 Commit b8033c10e2d1c32d1c5a672f4d4364dd58a0ab0d has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2022
@bors
Copy link
Collaborator

bors commented Feb 21, 2022

☔ The latest upstream changes (presumably #94205) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 21, 2022

@bors rollup-

@lcnr
Copy link
Contributor Author

lcnr commented Feb 21, 2022

@bors r=oli-obk

@lcnr lcnr closed this Feb 21, 2022
@bors
Copy link
Collaborator

bors commented Feb 21, 2022

📌 Commit 4b460edfab905b4553a67968c7d0b6574b34256a has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2022
@lcnr lcnr reopened this Feb 21, 2022
@bors
Copy link
Collaborator

bors commented Feb 22, 2022

☔ The latest upstream changes (presumably #94225) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 22, 2022

@bors p=1 bitrotty

@lcnr
Copy link
Contributor Author

lcnr commented Feb 22, 2022

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Feb 22, 2022

📌 Commit ee0b564 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2022
@bors
Copy link
Collaborator

bors commented Feb 22, 2022

⌛ Testing commit ee0b564 with merge 9ecd75b...

@bors
Copy link
Collaborator

bors commented Feb 22, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9ecd75b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2022
@bors bors merged commit 9ecd75b into rust-lang:master Feb 22, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 22, 2022
This was referenced Feb 22, 2022
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9ecd75b): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@lcnr lcnr deleted the print-mir-consts branch February 22, 2022 16:50
@b-naber b-naber mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @oli-obk @bors @rust-timer @rust-highfive @rustbot