Skip to content

Conversation

Xaeroxe
Copy link
Contributor

@Xaeroxe Xaeroxe commented Jan 15, 2022

Stabilizes the feature tracked at #92939

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2022
@ChrisDenton
Copy link
Member

ChrisDenton commented Mar 9, 2022

@rustbot label T-libs-api O-windows

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. O-windows Operating system: Windows labels Mar 9, 2022
@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Mar 9, 2022

FCP started here: #92939 (comment)

@@ -159,7 +159,7 @@ pub trait CommandExt: Sealed {
///
/// This is useful for passing arguments to `cmd.exe /c`, which doesn't follow
/// `CommandLineToArgvW` escaping rules.
#[unstable(feature = "windows_process_extensions_raw_arg", issue = "29494")]
#[stable(feature = "windows_process_extensions_raw_arg", since = "1.61.0")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be sure to update this version number before we merge

@Xaeroxe Xaeroxe marked this pull request as draft March 11, 2022 15:40
@dtolnay dtolnay marked this pull request as ready for review April 4, 2022 17:16
@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2022

@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2022

📌 Commit 66e05c2 has been approved by dtolnay

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#92942 (stabilize windows_process_extensions_raw_arg)
 - rust-lang#94817 (Release notes for 1.60.0)
 - rust-lang#95343 (Reduce unnecessary escaping in proc_macro::Literal::character/string)
 - rust-lang#95431 (Stabilize total_cmp)
 - rust-lang#95438 (Add SyncUnsafeCell.)
 - rust-lang#95467 (Windows: Synchronize asynchronous pipe reads and writes)
 - rust-lang#95609 (Suggest borrowing when trying to coerce unsized type into `dyn Trait`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c56cbf9 into rust-lang:master Apr 4, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 4, 2022
@Xaeroxe Xaeroxe deleted the raw_arg branch April 6, 2022 01:19
@dtolnay dtolnay self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants