Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cjgillot and others added 10 commits November 27, 2021 17:39
Checking only their DefId doesn't work because all slices have the same
fake DefId.

Fixes rust-lang#91347
Visit type in process_projection_elem.

Instead of reimplementing it for each visitor.
Bump compiler_builtins to 0.1.55 to bring in fixes for targets lackin…

…g atomic support.

This fixes a "Cannot select" LLVM error when compiling `compiler_builtins` for targets lacking atomics, like MSP430. Se rust-lang/compiler-builtins#441 for more info. This PR is a more general version of rust-lang#91248.
…le-if-types-are-the-same, r=GuillaumeGomez

Only show notable traits if both types are the same

Checking only their DefId doesn't work because all slices have the same
fake DefId.

Fixes rust-lang#91347
…wiser

Emit a warning on generic parameters with doc comments

Fixes rust-lang#90610
@rustbot rustbot added the rollup A PR which is a rollup label Nov 30, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

📌 Commit 7baafb1 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 30, 2021
@bors
Copy link
Collaborator

bors commented Dec 1, 2021

⌛ Testing commit 7baafb1 with merge d384ff7...

@bors
Copy link
Collaborator

bors commented Dec 1, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d384ff7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2021
@bors bors merged commit d384ff7 into rust-lang:master Dec 1, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 1, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d384ff7): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Large improvement in instruction counts (up to -2.7% on incr-unchanged builds of deeply-nested-async)
  • Very large regression in instruction counts (up to 7.1% on incr-unchanged builds of clap-rs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Dec 1, 2021
@rylev
Copy link
Member

rylev commented Dec 7, 2021

@matthiaskrgr this seems a bit hard to tell where the regression is coming from, but it is a quite a large regression in a real-world crate (albeit one that is a tiny bit noisy). #91366 and #91397 only really touch rustdoc so that's unlikely the culprit. PRs where code is removed or added can be a source of regressions so I wouldn't rule out the others, but we may want to investigate the bump of compiler builtins first.

@matthiaskrgr matthiaskrgr deleted the rollup-a2whn8m branch December 12, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants