Skip to content

Unbreak and update RLS #87345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2021
Merged

Unbreak and update RLS #87345

merged 4 commits into from
Jul 23, 2021

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Jul 21, 2021 •
edited
Loading

Closes #86905
Closes #86606
Closes #86607

This also prunes old mio 0.6 thanks to Tokio 1.0 bump, so this should now build on aarch64 Windows.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 (need to get this in before beta bump)

@bors
Copy link
Collaborator

bors commented Jul 22, 2021

📌 Commit 5fcb726 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2021
@bors
Copy link
Collaborator

bors commented Jul 23, 2021

⌛ Testing commit 5fcb726 with merge 00513ad59a448859cc4810030cb61b6df99e0451...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 23, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 23, 2021

📌 Commit a44abe5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2021
@bors
Copy link
Collaborator

bors commented Jul 23, 2021

⌛ Testing commit a44abe5 with merge 4a1f419...

@bors
Copy link
Collaborator

bors commented Jul 23, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4a1f419 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2021
@bors bors merged commit 4a1f419 into rust-lang:master Jul 23, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 23, 2021
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #87345!

Tested on commit 4a1f419.
Direct link to PR: #87345

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 23, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#87345!
08f36cb 
Tested on commit rust-lang/rust@4a1f419.
Direct link to PR: <rust-lang/rust#87345>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#86143 RLS does not build on aarch64 Windows
6 participants
@Xanewok @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @rustbot