Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented May 1, 2021

Parse unsupported "default field const values":

struct S {
    field: Type = const_val,
}

Recover from small : typo and provide suggestion:

struct S {
    field; Type,
    field2= Type,
}

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2021
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after @ArniDagur's comment is resolved.

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2021
@bors

This comment has been minimized.

@estebank estebank force-pushed the parse-struct-field-default branch from 3d90386 to cddf892 Compare May 12, 2021 01:45
Parse unsupported "default field const values":

```rust
struct S {
    field: Type = const_val,
}
```

Recover from small `:` typo and provide suggestion:

```rust
struct S {
    field; Type,
    field2= Type,
}
```
@estebank estebank force-pushed the parse-struct-field-default branch from cddf892 to 7697ce4 Compare May 12, 2021 01:49
@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented May 12, 2021

📌 Commit 7697ce4 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2021
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#84793 (Recover from invalid `struct` item syntax)
 - rust-lang#85117 (Move global click handlers to per-element ones.)
 - rust-lang#85141 (Update documentation for SharedContext::maybe_collapsed_doc_value)
 - rust-lang#85174 (Fix border radius for doc code blocks in rustdoc)
 - rust-lang#85205 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9461780 into rust-lang:master May 12, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 12, 2021
@estebank estebank deleted the parse-struct-field-default branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants