Skip to content

Conversation

cjgillot
Copy link
Contributor

This is a re-implementation from scratch of the dep-graph storage.

Instead of keeping the deserialized dep-graph immutable in memory,
this implementation modifies it in-place, and appends new dep-nodes to it.

The graph is cleaned-up at saving time, where all the nodes are renumbered to remove stale nodes.

r? @ghost

@jyn514 jyn514 added A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2021
@bors
Copy link
Collaborator

bors commented Feb 20, 2021

⌛ Trying commit 16d80aed4c981fa64a23bdd86665e6d424d00e31 with merge 3e82a8e64b10e2ad24021e1bd97e5374fbfa9757...

@bors
Copy link
Collaborator

bors commented Feb 20, 2021

☔ The latest upstream changes (presumably #70951) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 20, 2021
@bors
Copy link
Collaborator

bors commented Feb 20, 2021

☀️ Try build successful - checks-actions
Build commit: 3e82a8e64b10e2ad24021e1bd97e5374fbfa9757 (3e82a8e64b10e2ad24021e1bd97e5374fbfa9757)

@rust-timer
Copy link
Collaborator

Queued 3e82a8e64b10e2ad24021e1bd97e5374fbfa9757 with parent e7c23ab, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (3e82a8e64b10e2ad24021e1bd97e5374fbfa9757): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 21, 2021
@bjorn3
Copy link
Member

bjorn3 commented Feb 21, 2021

Significant regressions of up to 6%.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 22, 2021
@bors
Copy link
Collaborator

bors commented Feb 22, 2021

⌛ Trying commit 10844018aa5118c4407b8c512ac2c55e03ea0a47 with merge 7d3e46cdccabc8f3cfc056edc05a570756da768c...

@bors
Copy link
Collaborator

bors commented Feb 22, 2021

☀️ Try build successful - checks-actions
Build commit: 7d3e46cdccabc8f3cfc056edc05a570756da768c (7d3e46cdccabc8f3cfc056edc05a570756da768c)

@rust-timer
Copy link
Collaborator

Queued 7d3e46cdccabc8f3cfc056edc05a570756da768c with parent a15f484, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (7d3e46cdccabc8f3cfc056edc05a570756da768c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 24, 2021
@bors
Copy link
Collaborator

bors commented Feb 24, 2021

⌛ Trying commit 91734f1 with merge de903c91da2158c76094697c62f036b7a3324155...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Feb 24, 2021

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2021
@cjgillot
Copy link
Contributor Author

With atomics
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

⌛ Trying commit 0c7de43 with merge cfb73662247a17bcf07f635d74389d1aeb2df26c...

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

☀️ Try build successful - checks-actions
Build commit: cfb73662247a17bcf07f635d74389d1aeb2df26c (cfb73662247a17bcf07f635d74389d1aeb2df26c)

@rust-timer
Copy link
Collaborator

Queued cfb73662247a17bcf07f635d74389d1aeb2df26c with parent b36f770, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cfb73662247a17bcf07f635d74389d1aeb2df26c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 25, 2021
@cjgillot cjgillot closed this Mar 6, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Mar 6, 2021

Closed in favour of #82780.

@cjgillot cjgillot deleted the neograph branch September 21, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants