Skip to content

Box generator-related Body fields #81114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Box generator-related Body fields #81114

merged 1 commit into from
Mar 4, 2021

Conversation

bugadani
Copy link
Contributor

Might save some memory on functions that aren't generators.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2021
@bugadani bugadani marked this pull request as draft January 17, 2021 13:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bugadani bugadani marked this pull request as ready for review January 17, 2021 16:27
@jyn514
Copy link
Member

jyn514 commented Jan 17, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
bjorn3
bjorn3 reviewed Jan 17, 2021
View reviewed changes
@bors

This comment has been minimized.

Sign in to view
@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 17, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (eb047c65a4179998b3d4524011b5063d0e909cdd): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 17, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jan 17, 2021

A slight improvement of up to 0.4%.

@bugadani
Copy link
Contributor Author

That's actually pretty interesting. Unfortunately, one of the changes had to be reverted because of the test break

@bors

This comment has been minimized.

Sign in to view
@bugadani bugadani changed the title [EXPERIMENT] Box generator-related Body fields Box generator-related Body fields Jan 18, 2021
@bors

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 26, 2021

⌛ Trying commit 0ede2fac1fe9a890f9f41ae611ba5ffa05d8a74e with merge 466d4c7c84f3e61387752b11a942ebaa244b38b0...

@estebank
Copy link
Contributor

estebank commented Mar 1, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 1, 2021

📌 Commit b97eb23 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2021
@bors
Copy link
Collaborator

bors commented Mar 1, 2021

⌛ Testing commit b97eb23 with merge 672ef917c377e07636e3b670b690599e7cb81ad1...

@bors
Copy link
Collaborator

bors commented Mar 2, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@estebank
Copy link
Contributor

estebank commented Mar 2, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2021
@bors
Copy link
Collaborator

bors commented Mar 2, 2021

⌛ Testing commit b97eb23 with merge 670856d838775d6e7bdf9a86d4a75ce764c8b681...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2021
@bugadani
Copy link
Contributor Author

bugadani commented Mar 3, 2021

This time the error was:

warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/new_debug_unreachable/1.0.4/download`, got 503
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/new_debug_unreachable/1.0.4/download`, got 503
error: failed to download from `https://crates.io/api/v1/crates/new_debug_unreachable/1.0.4/download`

Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/new_debug_unreachable/1.0.4/download`, got 503

@estebank
Copy link
Contributor

estebank commented Mar 3, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
@bors
Copy link
Collaborator

bors commented Mar 4, 2021

⌛ Testing commit b97eb23 with merge 6f7673d...

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 6f7673d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2021
@bors bors merged commit 6f7673d into rust-lang:master Mar 4, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 4, 2021
@bugadani bugadani deleted the generator branch March 4, 2021 18:45
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@estebank estebank

Labels
I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.