Skip to content

Cleanup Resolver::<clone|into>_outputs methods #72636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Cleanup Resolver::<clone|into>_outputs methods #72636

merged 1 commit into from
May 29, 2020

Conversation

marmeladema
Copy link
Contributor

Follow-up cleanup work of #72402

First commit has been split out from #72552

r? @ecstatic-morse

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2020
@petrochenkov petrochenkov self-assigned this May 27, 2020
petrochenkov
petrochenkov reviewed May 27, 2020
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2020
@marmeladema marmeladema requested a review from petrochenkov May 27, 2020 12:17
@petrochenkov
Copy link
Contributor

r=me after squashing the commits.

@marmeladema
Store LocalDefId directly in rustc_resolve::Resolver where possible
81f8ee4 
This commit also include the following changes:
* Remove unused `hir::Map::as_local_node_id` method
* Remove outdated comment about `hir::Map::local_def_id` method
* Remove confusing `GlobMap` type alias
* Use `LocalDefId` instead of `DefId` in `extern_crate_map`
* Use `LocalDefId` instead of `DefId` in `maybe_unused_extern_crates`
* Modify `extern_mod_stmt_cnum` query to accept a `LocalDefId` instead of a `DefId`
@marmeladema marmeladema force-pushed the resolver-outputs-def-id branch from a55a14a to 81f8ee4 Compare May 27, 2020 14:55
@marmeladema
Copy link
Contributor Author

@petrochenkov rebased and squashed

@marmeladema marmeladema requested a review from petrochenkov May 27, 2020 14:56
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 27, 2020

📌 Commit 81f8ee4 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2020
@petrochenkov petrochenkov mentioned this pull request May 27, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 29, 2020
Merged
@bors bors merged commit 48ea37b into rust-lang:master May 29, 2020
@marmeladema marmeladema deleted the resolver-outputs-def-id branch April 24, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov Awaiting requested review from petrochenkov

Assignees

@petrochenkov petrochenkov

@ecstatic-morse ecstatic-morse

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Milestone
No milestone