Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Nov 7, 2019

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 29 commits October 29, 2019 13:54
Have tidy ensure that we document all `unsafe` blocks in libcore

cc @rust-lang/libs

I documented a few and added ignore flags on the other files. We can incrementally document the files, but won't regress any files this way.
…, r=kinnison

[rustdoc] add sub settings

This PR is to give a finer control over what types are automatically expanded or not as well as the possibility to add sub-settings in the settings page.

![Screenshot from 2019-09-23 00-46-14](https://user-images.githubusercontent.com/3050060/65395521-15aff300-dd9c-11e9-9437-429ca347d455.png)

r? @Mark-Simulacrum
Update some build-pass ui tests to use check-pass where applicable

Helps with issue rust-lang#62277.
invalid_value lint: fix help text

Now that we also warn about `MaybUninit::uninit().assume_init()`, just telling people "use `MaybeUninit`" isn't always sufficient. And anyway this seems like an important enough point to mention it here.
@Centril
Copy link
Contributor Author

Centril commented Nov 7, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Collaborator

bors commented Nov 7, 2019

📌 Commit 333899a has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2019
@Centril Centril added the rollup A PR which is a rollup label Nov 7, 2019
@bors
Copy link
Collaborator

bors commented Nov 7, 2019

⌛ Testing commit 333899a with merge 3f0f2bf...

bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 5 pull requests

Successful merges:

 - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore)
 - #64696 ([rustdoc] add sub settings)
 - #65916 (syntax: move stuff around)
 - #66087 (Update some build-pass ui tests to use check-pass where applicable)
 - #66182 (invalid_value lint: fix help text)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Nov 7, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2019
@Centril
Copy link
Contributor Author

Centril commented Nov 7, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2019
@bors
Copy link
Collaborator

bors commented Nov 7, 2019

⌛ Testing commit 333899a with merge b3909b9022886b13ab9883e445c831307c3a76f5...

@bors
Copy link
Collaborator

bors commented Nov 7, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2019
@Centril
Copy link
Contributor Author

Centril commented Nov 7, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2019
@bors
Copy link
Collaborator

bors commented Nov 7, 2019

⌛ Testing commit 333899a with merge e8f43b7...

bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 5 pull requests

Successful merges:

 - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore)
 - #64696 ([rustdoc] add sub settings)
 - #65916 (syntax: move stuff around)
 - #66087 (Update some build-pass ui tests to use check-pass where applicable)
 - #66182 (invalid_value lint: fix help text)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Nov 8, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing e8f43b7 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants