Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 27, 2019

Successful merges:

Failed merges:

r? @ghost

LooMaclin and others added 29 commits April 2, 2019 05:58
- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser
…error_reporting_in_check_in_alloc, r=RalfJung

Improve miri error reporting in check_in_alloc

Fixes rust-lang#57128

r? @RalfJung @oli-obk
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
…lwoerister

Reword malformed attribute input diagnostics

- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser

Split up from rust-lang#61026, where there's prior conversation.
Use .await syntax instead of await!

Tiny doc fix.
@Centril
Copy link
Contributor Author

Centril commented May 27, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Collaborator

bors commented May 27, 2019

📌 Commit 88115b9 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2019
@Centril Centril closed this May 27, 2019
@Centril Centril deleted the rollup-zn72xhe branch May 27, 2019 15:26
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants