[let_chains, 2/6] Introduce `Let(..)` in AST, remove IfLet + WhileLet and parse let chains#60861

Merged

bors merged 35 commits intorust-lang:masterfrom

Centril:let-chains-ast-intro

Jun 23, 2019

Commits on Jun 22, 2019

let_chains: Remove ast::ExprKind::{IfLet, WhileLet} and introduce ::Let.
Centril
committed
let_chains: Remove ast::ExprKind::{IfLet, WhileLet} from visitors and introduce ::Let.
Centril
committed
let_chains: Handle it in AST pretty printing.
Centril
committed
let_chains: Add support for parsing let expressions.
Centril
committed
let_chains: Handle in resolve.
Centril
committed
let_chains: Handle in unused parenthesis lint.
Centril
committed
let_chains: Handle disallowing of let chains in places lowering won't support.
Centril
committed
let_chains: Adjust lowering logic in lieu of ::Let.
Centril
committed
let_chains: Add feature gate.
Centril
committed
let_chains: Add tests for places where let expressions aren't allowed.
Centril
committed
let_chains: Add feature gate tests.
Centril
committed
let_chains: Adjust unnecessary parens tests.
Centril
committed
let_chains: Add test protecting the precedence of && in relation to other things.
Centril
committed
let_chains: Remove redundant tests in syntax-ambiguity-*.rs.
Centril
committed
let_chains: Test pretty output for simple stable if-let.
Centril
committed
let_chains: Comment out Let in ident_can_begin_expr.
Centril
committed
let_chains: Improve documentation for ast::ExprKind::Let(..).
Centril
committed
let_chains: Fix outdated doc-comment re. 'parse_if_expr'.
Centril
committed
let_chains: scrutinee -> head expression.
Centril
committed
let_chains: Change AST validation strategy slightly.
Centril
committed
let_chains: Account for const generics in validation tests.
Centril
committed
let_chains: scrutinee -> condition
Centril
committed
let_chains: Fuse PatternSource::Let & ::LetExpr.
Centril
committed
let_chains: readd kw::let to ident_can_begin_expr.
Centril
committed
let_chains: Inline visit_expr_with_let_maybe_allowed.
Centril
committed
let_chains: Move feature gating to pre-expansion.
Centril
committed
let_chains: Adjust tests for pre-expansion gating.
Centril
committed
let_chains: Remove ast_validation logic in favor of lowering with recovery.
Centril
committed
let_chains: --bless tests due to recovery in lowering.
Centril
committed
let_chains: Refactor parse_{if,while}_expr a bit.
Centril
committed
let_chains: Fix bugs in pretty printing.
Centril
committed
let_chains: Add test cases to pprust-expr-roundtrip.
Centril
committed
let_chains: More accurately describe `ast::ExprKind::Let`.

Centril
and
petrochenkov
committed
let_chains: Revert 'fn with' in ast_validation.
Centril
committed
let_chains: note re. back-compat wrt. expr beginning.
Centril
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[let_chains, 2/6] Introduce `Let(..)` in AST, remove IfLet + WhileLet and parse let chains#60861

Commits on Jun 22, 2019

let_chains: Remove ast::ExprKind::{IfLet, WhileLet} and introduce ::Let.

let_chains: Remove ast::ExprKind::{IfLet, WhileLet} from visitors and introduce ::Let.

let_chains: Handle it in AST pretty printing.

let_chains: Add support for parsing let expressions.

let_chains: Handle in resolve.

let_chains: Handle in unused parenthesis lint.

let_chains: Handle disallowing of let chains in places lowering won't support.

let_chains: Adjust lowering logic in lieu of ::Let.

let_chains: Add feature gate.

let_chains: Add tests for places where let expressions aren't allowed.

let_chains: Add feature gate tests.

let_chains: Adjust unnecessary parens tests.

let_chains: Add test protecting the precedence of && in relation to other things.

let_chains: Remove redundant tests in syntax-ambiguity-*.rs.

let_chains: Test pretty output for simple stable if-let.

let_chains: Comment out Let in ident_can_begin_expr.

let_chains: Improve documentation for ast::ExprKind::Let(..).

let_chains: Fix outdated doc-comment re. 'parse_if_expr'.

let_chains: scrutinee -> head expression.

let_chains: Change AST validation strategy slightly.

let_chains: Account for const generics in validation tests.

let_chains: scrutinee -> condition

let_chains: Fuse PatternSource::Let & ::LetExpr.

let_chains: readd kw::let to ident_can_begin_expr.

let_chains: Inline visit_expr_with_let_maybe_allowed.

let_chains: Move feature gating to pre-expansion.

let_chains: Adjust tests for pre-expansion gating.

let_chains: Remove ast_validation logic in favor of lowering with recovery.

let_chains: --bless tests due to recovery in lowering.

let_chains: Refactor parse_{if,while}_expr a bit.

let_chains: Fix bugs in pretty printing.

let_chains: Add test cases to pprust-expr-roundtrip.

let_chains: More accurately describe `ast::ExprKind::Let`.

let_chains: Revert 'fn with' in ast_validation.

let_chains: note re. back-compat wrt. expr beginning.