Unbreak the RLS #57285
Closed
Unbreak the RLS #57285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakage was due to rust-lang#55937, which seemed to introduce a regression (tracked over at rust-lang#57280).
|
rust-highfive
added
the
S-waiting-on-review
|
@Xanewok seems fine -- I expect we'll have a fix for the regression soon though. But I guess it makes sense to move forward anyway? |
|
I think it doesn’t hurt to get this to unbreak the toolstate so there’s no pressure on the regression fix, but I have no idea - maybe it makes sense to wait, if the regression fix is important and will land soon! |
|
Fix is in #57304 |
|
Awesome, thanks! I’ll close this then, since the only thing this updates is working around this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakage was due to #55937, which seems to have introduced a regression (tracked over at #57280).
Clippy updates don't matter in-tree because we patch it with the in-tree version - rust-lang/rls@085e926 is the important change.
r? @nikomatsakis
cc @nrc