Replace new-in-1.26 ParsePathError with ! #49404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has never been stable, so we can just get rid of the nominal type.
rust-highfive
added
the
S-waiting-on-review
kennytm
added
beta-nominated
|
Blocked by decision in #49593. |
kennytm
added
S-blocked
TimNN
added
S-blocked
TimNN
added
S-blocked
|
☔ The latest upstream changes (presumably #50413) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ParsePathError has been reverted by #50401, and thus this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "definitely ok because it only changes things that have never been released in stable" version of #49039. Posting this in case it's decided there that changing
string::ParseErroris undesirable.r? @alexcrichton