-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add read, read_string, and write functions to std::fs #45837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd518ac
Add File::read_contents and File::write_contents convenience functions.
SimonSapin c670424
Move `File::{read,write}_contents` to `fs::{read,write}` free functions.
SimonSapin a379e69
Add `std::fs::read_utf8`, based on `File::open` and `read_to_string`
SimonSapin 7e2f756
Generalize fs::write from &[u8] to AsRef<[u8]>
SimonSapin 1cf11b3
Rename fs::read_utf8 to read_string
SimonSapin c5eff54
fs::{read, read_string, write}: add tracking issue number
SimonSapin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could look up the file size first and use
Vec::with_capacity
. It might mean as extra system call when reading a tiny file, but it is a huge speedup (up to 2× on my system) when reading large files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
read_to_end
should be responsible for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Through specialization on
Seek
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specialization of
read_to_end
is a good idea. Filed #45851.Note that callers of
read_to_end
can already avoid quadratic behavior by passing in a pre-allocated buffer. That workaround isn't available with the functions in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve opened a PR with a prototype: #45928