Skip to content

Conversation

Mark-Simulacrum and others added 18 commits June 22, 2017 21:18
config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.
So ARM had quite a few codegen bugs on LLVM 4.0 which are fixed on LLVM
trunk. This backports 5 of them:
r297871 - ARM: avoid clobbering register in v6 jump-table expansion.
    - fixes rust-lang#42248
r294949 - [Thumb-1] TBB generation: spot redefinitions of index
r295816 - [ARM] Fix constant islands pass.
r300870 - [Thumb-1] Fix corner cases for compressed jump tables
r302650 - [IfConversion] Add missing check in
IfConversion/canFallThroughTo
    - unblocks rust-lang#39409
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2017

📌 Commit fc87577 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit fc87577 with merge 0a75a245af2952b94a33f1ca964b76c33a62365b...

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0a75a245af2952b94a33f1ca964b76c33a62365b to beta...

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 23, 2017
@Mark-Simulacrum
Copy link
Member

....This appears to have passed CI, but bors didn't actually merge as far as I can tell. I guess

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Make wasm32 buildbot test LLVM backend #42784

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

📌 Commit fc87577 has been approved by alexcrichton

@Mark-Simulacrum
Copy link
Member

Ah, I guess:

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

⌛ Testing commit fc87577 with merge cdb1b458470b2f73e5344c96ffa5dfe294614c48...

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

Failure seems spurious:

[01:01:22] failures:
[01:01:22]
[01:01:22] ---- [run-make] run-make/sanitizer-leak stdout ----
[01:01:22]
[01:01:22] error: make failed
[01:01:22] status: exit code: 2
[01:01:22] command: "make"
[01:01:22] stdout:
[01:01:22] ------------------------------------------
[01:01:22] LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu:/checkout/obj/build/x86_64-unknown-linux-gnu
[01:01:22] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu/leak 2>&1 | grep -q 'detected memory leaks'
[01:01:22] Makefile:6: recipe for target 'all' failed
[01:01:22]
[01:01:22] ------------------------------------------
[01:01:22] stderr:
[01:01:22] ------------------------------------------
[01:01:22] make: *** [all] Error 1
[01:01:22]
[01:01:22] ------------------------------------------
[01:01:22]
[01:01:22] thread '[run-make] run-make/sanitizer-leak' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2480
[01:01:22] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:01:22]
[01:01:22]
[01:01:22] failures:
[01:01:22]     [run-make] run-make/sanitizer-leak
[01:01:22]
[01:01:22] test result: FAILED. 148 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

⌛ Testing commit fc87577 with merge 5181b24...

bors added a commit that referenced this pull request Jun 25, 2017
[beta] backports

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.

Still testing locally.

cc @rust-lang/compiler

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Jun 25, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

os x timeout

@bors
Copy link
Collaborator

bors commented Jun 25, 2017

⌛ Testing commit fc87577 with merge 046a91e...

bors added a commit that referenced this pull request Jun 25, 2017
[beta] backports

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.

Still testing locally.

cc @rust-lang/compiler

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Jun 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 046a91e to beta...

@Mark-Simulacrum
Copy link
Member

@bors r=alexcrichton retry

@bors
Copy link
Collaborator

bors commented Jun 26, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Jun 26, 2017

📌 Commit fc87577 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: p=1

(beta backports)

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

⌛ Testing commit fc87577 with merge b14aa411142251273c0a1ec3d4c07b5d4cff855b...

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

Presuming spurious failure, @bors retry

[00:57:26] ---- [run-make] run-make/sanitizer-leak stdout ----
[00:57:26] 	
[00:57:26] error: make failed
[00:57:26] status: exit code: 2
[00:57:26] command: "make"
[00:57:26] stdout:
[00:57:26] ------------------------------------------
[00:57:26] LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib:" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu  -C opt-level=1 -g -Z sanitizer=leak -Z print-link-args leak.rs | grep -q librustc_lsan
[00:57:26] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/sanitizer-leak.stage2-x86_64-unknown-linux-gnu/leak 2>&1 | grep -q 'detected memory leaks'
[00:57:26] Makefile:6: recipe for target 'all' failed
[00:57:26] 
[00:57:26] ------------------------------------------
[00:57:26] stderr:
[00:57:26] ------------------------------------------
[00:57:26] make: *** [all] Error 1
[00:57:26] 
[00:57:26] ------------------------------------------
[00:57:26] 
[00:57:26] thread '[run-make] run-make/sanitizer-leak' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2480
[00:57:26] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:57:26] 
[00:57:26] 
[00:57:26] failures:
[00:57:26]     [run-make] run-make/sanitizer-leak
[00:57:26] 
[00:57:26] test result: �[31mFAILED�(B�[m. 148 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

⌛ Testing commit fc87577 with merge c87916d14bbc1dcd1b4f64bb4e076853408ca3ed...

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c87916d14bbc1dcd1b4f64bb4e076853408ca3ed to beta...

@kennytm
Copy link
Member

kennytm commented Jun 27, 2017

Something's wrong with @bors, 10 minutes and the beta branch is still not updated. The queue's status is "error".

@Mark-Simulacrum
Copy link
Member

I think @bors doesn't like this pull request. I'm going to try and reopen as a new PR I guess..

@Mark-Simulacrum
Copy link
Member

I've reopened this as #42927 in the hopes that @bors like it more.

bors added a commit that referenced this pull request Jun 27, 2017
[beta] backports

Reopening #42841 as a new PR due to bors flakiness.

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.
bors added a commit that referenced this pull request Jun 27, 2017
[beta] backports

Reopening #42841 as a new PR due to bors flakiness.

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.