introduce a fudge_regions_if_ok to address false region edges
#37659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Nov 9, 2016
| /// Assumptions: | ||
| /// - no new type variables are created during `f()` (asserted | ||
| /// below); this simplifies our logic since we don't have to | ||
| /// check for escaping type variables |
There was a problem hiding this comment.
This will break down once lazy normalization happens, right? Not that it blocks the PR.
|
@bors r+ |
|
@bors: r+ |
|
📌 Commit c428535 has been approved by |
|
er, @bors: r=eddyb |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c428535 has been approved by |
alexcrichton
added
the
T-compiler
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 11, 2016
…eddyb introduce a `fudge_regions_if_ok` to address false region edges Fixes rust-lang#37655. r? @eddyb cc @sfackler
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 12, 2016
…eddyb introduce a `fudge_regions_if_ok` to address false region edges Fixes rust-lang#37655. r? @eddyb cc @sfackler
bors
added a commit
that referenced
this pull request
Nov 12, 2016
Rollup of 30 pull requests - Successful merges: #37190, #37368, #37481, #37503, #37527, #37535, #37551, #37584, #37600, #37613, #37615, #37659, #37662, #37669, #37682, #37688, #37690, #37692, #37693, #37694, #37695, #37696, #37698, #37699, #37705, #37708, #37709, #37716, #37724, #37727 - Failed merges: #37640, #37689, #37717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37655.
r? @eddyb
cc @sfackler