Rollup of 7 pull requests #24786
Closed
Rollup of 7 pull requests #24786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveklabnik
commented
Apr 24, 2015
steveklabnik
commented
- Successful merges: Fix quote tests #24718, Remove the grammar from the reference #24729, Remove duplicate feature gate tests #24751, Byte string literals are now fixed-size arrays #24766, Reference manual 3.5.2.1.5 #24769, Remove reference to 'to' #24772, Reference: Update 7.2.20 (for loops) and fix formatting #24775
- Failed merges: More small syntax changes in reference.md #24760
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively.
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
`is` and `us` suffixes are deprecated in favor of `isize` and `usize`.
* `for` loops now use `IntoIterator` instead of just `Iterator` * Simplify the example by removing unnecessary `Vec::iter` call.
Re-enables the test.
Re-enables the test.
Sniped from @rprichard's work in rust-lang#24537. r? @alexcrichton
…labnik From rust-lang#24723 (comment) : > Yes, I've been meaning to just remove it in favor of GRAMMAR.md > - steveklabnik
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
`is` and `us` suffixes are deprecated in favor of `isize` and `usize`.
Update 7.2.20 (`for` expressions): * `for` loops now use `IntoIterator` instead of just `Iterator` * Simplify the example by removing unnecessary `Vec::iter` call. ...and a fix for a minor formatting error. r? @steveklabnik
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit ad9da5e has been approved by |
|
@bors: r+ p=1 |
|
📌 Commit 1f8dc51 has been approved by |
I forgot these heavily use associated types, so move it after that as well.
|
@bors: r+ p=1 |
|
📌 Commit 37aa193 has been approved by |
|
⌛ Testing commit 37aa193 with merge 5fbef3f... |
|
💔 Test failed - auto-mac-32-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.