correct reference wrt shifts #23662
Merged
correct reference wrt shifts #23662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1263,9 +1263,6 @@ be undesired. | |||
| * Exiting without calling destructors | |||
| * Sending signals | |||
| * Accessing/modifying the file system | |||
| * Unsigned integer overflow (well-defined as wrapping) | |||
There was a problem hiding this comment.
Hmm. You may actually want to leave these two bullet points in: We are continuing to use well-defined fallbacks when one's code is compiled without the overflow checking turned on, as discussed in the Arithmetic Overflow RFC; its the part where we say what the "defined result" is for each operation of interest.
There was a problem hiding this comment.
roger. Since that's conditional, I wasn't sure.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 24, 2015
I assume since both shifts say the same thing, I should fix both of them, but then I realized I don't strictly know about left shift. Fixes rust-lang#23421 r? @pnkfelix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume since both shifts say the same thing, I should fix both of them, but then I realized I don't strictly know about left shift.
Fixes #23421
r? @pnkfelix