Skip to content

Conversation

@saethlin
Copy link
Member

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2026
@saethlin saethlin marked this pull request as ready for review January 17, 2026 18:51
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

@BoxyUwU BoxyUwU changed the title Disable SimplifyComparisonIntegral [beta] Disable SimplifyComparisonIntegral Jan 17, 2026
@Mark-Simulacrum
Copy link
Member

Rolled into #151270, the implementation looks trivially reasonable to me (though I'm not an expert).

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2026
@scottmcm
Copy link
Member

Agreed; the implementation change is trivially reasonable.

rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
[beta] backports

*  [beta] Disable SimplifyComparisonIntegral #151267 
*  Use the old homu bors e-mail address again #150959 

Does not backport other nominated PRs:

* Only use SSA locals in SimplifyComparisonIntegral #150925  (replaced with the disablement PR)
* Don't try to evaluate const blocks during constant promotion #150557 (backport essentially denied at this point)
* Use realstd current thread static variables in tests #150131 (as far as I can tell, this only affects internal std tests and hasn't landed in time for backport)

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants