Unify and deduplicate float tests (exp, log, hyperbolic, gamma) #151167
+281
−808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the following tests from library/std/tests/floats/ to use the unified float_test! macro infrastructure in library/coretests/tests/floats/mod.rs: - exp, exp2: Exponential functions - ln, log, log2, log10: Logarithmic functions - asinh, acosh, atanh: Inverse hyperbolic functions - gamma, ln_gamma: Gamma functions This eliminates duplicate test code across f16, f32, f64, and f128 test files.
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
The Cranelift codegen backend (cg_clif) does not support f16/f128 math intrinsics, causing linker errors. Add `randomized_layouts` to check-cfg.
The Cranelift codegen backend (cg_clif) does not support f16/f128 math intrinsics, which causes linker errors for undefined symbols like logf16, expf16, etc. Add `not(randomized_layouts)` to the cfg attributes for f16 and f128 math tests to skip them when running under Cranelift's randomized layout testing, which sets the `randomized_layouts` cfg flag.
This comment has been minimized.
This comment has been minimized.
After migrating exp, log, hyperbolic, and gamma function tests to the unified float_test! macro infrastructure in library/coretests, the TOL constant in library/std/tests/floats/f128.rs became unused. This removes the dead code to fix the CI warning: "warning: constant `TOL` is never used" The remaining constants (TOL_PRECISE, TOL_IMPR) are still used by test_real_consts and test_powf respectively.
Author
Contributor
|
Hello! Thank you for the interest, but I am afraid this conflicts with #148206 |
Author
Contributor
|
Unfortunately I have no recommendations, but I think you were on the right track looking for E-Easy issues. Just keep your eyes peeled, or ask on Zulip if you are looking for something specific :) |
Contributor
For future reference, please do not include these AI-generated summaries. They're pure noise - we know what the functions do, GitHub shows you the +/- diffstat, and the third section is meaningless (the goal of review is to figure out if these things are done correctly. The statement happens to be wrong because I see some things that aren't). |
Author
Ok then I will close this branch, thank you for the feedback |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates duplicated float tests from
library/std/tests/floats/to use the unifiedfloat_test!macro infrastructure inlibrary/coretests/tests/floats/mod.rs.Tests migrated:
exp,exp2- Exponential functionsln,log,log2,log10- Logarithmic functionsasinh,acosh,atanh- Inverse hyperbolic functionsgamma,ln_gamma- Gamma functionsResult:
All tests properly handle:
target_has_reliable_f16_math/target_has_reliable_f128_math#[cfg(not(miri))]#[cfg(false)]Fixes #141726
Test plan
./x.py test library/coretests --stage 1passes locally./x.py test library/std --stage 1passes locally