Clippy subtree update #150818

flip1995 · 2026-01-08T17:52:57Z

r? Manishearth

Cargo.lock update due to askama bump to be in line with the Rust repo.

changelog: [`transmuting_null`]: now checks single expression const blocks and blocks

…ubtree-update

This fixes the ICE reported by rejecting `const` blocks in pattern position during AST lowering. Previously, `ExprKind::ConstBlock` could reach HIR as `PatExprKind::ConstBlock`, allowing invalid patterns to be type-checked and triggering an ICE. This patch removes the lowering path for const blocks in patterns and emits a proper diagnostic instead. A new UI test is added to ensure the compiler reports a regular error and to prevent regressions.

rust-lang/rust-clippy#16224 changelog: [`double_parens`]: fix FP on macro repetition patterns

Closes rust-lang/rust-clippy#16293 Also contains fixes of several other lints, on handling macros changelog: [`checked_conversions`] fix wrongly unmangled macros changelog: [`manual_ignore_case_cmp`] fix wrongly unmangled macros changelog: [`manual_ilog2`] fix wrongly unmangled macros changelog: [`needless_bool_assign`] fix wrongly unmangled macros changelog: [`manual_is_multiple_of`] fix wrongly unmangled macros

Fairly simple and self explanatory, the actual config value is `allowed-duplicate-crates` not `allowed_duplicate_crates` and will throw an error if you use the wrong one. changelog: Fix typoed mention of config value using `_` of `-`

…8, r=dianne Fix ICE by rejecting const blocks in patterns during AST lowering (closes rust-lang#148138) This PR fixes the ICE reported in rust-lang#148138. The root cause is that `const` blocks aren’t allowed in pattern position, but the AST lowering logic still attempted to create `PatExprKind::ConstBlock`, allowing invalid HIR to reach type checking and trigger a `span_bug!`. Following the discussion in the issue, this patch removes the `ConstBlock` lowering path from `lower_expr_within_pat`. Any `ExprKind::ConstBlock` inside a pattern is now handled consistently with other invalid pattern expressions. A new UI test is included to ensure the compiler reports a proper error and to prevent regressions. Closes rust-lang#148138.

The original documentation had me confused for a couple of minutes. Now it should be more or less unambiguous. changelog: none

…lang#16084) Closes rust-lang/rust-clippy#14989 changelog: [`redundant_pattern_matching`] fix missing `)` in suggestion span

Extremely small change, -0.018% performance improvement on `tokio` Just some warmup for continuing on larger optimizations (i.e. `nonminimal_bool`) changelog:Remove allocations via String pre-allocating.

@blyxyas

This removes another single allocation (namely by writing into an already existing `String` instead of allocating a new one just to `push_str` it). r? @blyxyas --- changelog: none

rust-bors · 2026-01-08T19:51:56Z

💔 Test for c9f505d failed: CI. Failed jobs:

auto - pr-check-2 (web logs, enhanced plaintext logs)

Closes rust-lang/rust-clippy#16351 changelog: [`unnecessary_to_owned`] fix wrongly unmangled macros

…ubtree-update

samueltardieu · 2026-01-09T10:05:13Z

Darn, the MGCA literals support has been merged in the meantime!

samueltardieu · 2026-01-09T10:14:51Z

I'm testing https://github.com/samueltardieu/rust/tree/clippy-subtree-update with an updated version of my ConstArgKind commit to accomodate changes made in r-l/rust.

samueltardieu · 2026-01-09T10:20:29Z

@flip1995 I think you can replace my penultimate commit by the one from https://github.com/samueltardieu/rust/tree/clippy-subtree-update (1dd7896).

flip1995 · 2026-01-09T11:00:06Z

Ah thanks, didn't see your message until I fixed it myself.

samueltardieu · 2026-01-09T11:48:08Z

pr-check-2 is now green

@bors r=Manishearth,samueltardieu p=1 rollup=never

rust-bors · 2026-01-09T11:48:12Z

📌 Commit 330358a has been approved by Manishearth,samueltardieu

It is now in the queue for this repository.

rust-bors · 2026-01-10T01:19:03Z

☀️ Test successful - CI
Approved by: Manishearth,samueltardieu
Pushing 1191620 to main...

github-actions · 2026-01-10T01:21:59Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a3f2d5a (parent) -> 1191620 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1191620b8c4a93074796408afa538e086acf38c7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8181.4s -> 6303.2s (-23.0%)
aarch64-apple: 10384.8s -> 8395.8s (-19.2%)
dist-aarch64-llvm-mingw: 6829.9s -> 5615.1s (-17.8%)
dist-aarch64-apple: 7404.4s -> 6182.1s (-16.5%)
dist-sparcv9-solaris: 5576.2s -> 4880.5s (-12.5%)
dist-aarch64-msvc: 6722.5s -> 6069.4s (-9.7%)
i686-gnu-2: 4914.4s -> 5362.8s (+9.1%)
x86_64-msvc-ext1: 7785.0s -> 7091.0s (-8.9%)
aarch64-msvc-1: 7418.6s -> 6801.0s (-8.3%)
x86_64-msvc-ext3: 6855.1s -> 6308.0s (-8.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-10T02:02:32Z

Finished benchmarking commit (1191620): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results (primary 2.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	8
All ❌✅ (primary)	-	-	0

Bootstrap: 473.694s -> 472.536s (-0.24%)
Artifact size: 391.30 MiB -> 391.23 MiB (-0.02%)

profetia and others added 30 commits November 29, 2025 22:28

fix: redundant_pattern_matching misses ) in suggestion span

ae310e2

Clarify strlen_on_c_strings documentation

c17b4a2

transmuting_null: Check single expression const blocks and blocks

558ff51

changelog: [`transmuting_null`]: now checks single expression const blocks and blocks

fix: new_without_default misses where clause in new

a2102a5

fix: str_to_string wrongly unmangled macros

4c4b2a1

fix: bool_assert_comparison suggests wrongly for macros

1377de0

Make attr path symbols rather than idents

4d0dbee

fix: checked_conversions wrongly unmangled macros

bc943aa

fix: manual_ignore_case_cmp wrongly unmangled macros

ffbdb57

fix: manual_ilog2 wrongly unmangled macros

d30647b

fix: needless_bool_assign wrongly unmangled macros

01b3965

fix: needless_for_each FN when for_each is in the expr of a block

21eaa04

fix: manual_is_multiple_of wrongly unmangled macros

6bc6509

Merge commit '99edcadfd5f6f6e8da34b1ba62774b53f5ca3863' into clippy-s…

54e9e8c

…ubtree-update

Fix multiple_inherent_impl false negatives for generic impl blocks

ec91742

fix double_parens FP on macro repetition patterns

e12e19d

move multiple_bound_locations to style

871cc74

Fix double_parens FP on macro repetition patterns (rust-lang#16301)

1a1e335

rust-lang/rust-clippy#16224 changelog: [`double_parens`]: fix FP on macro repetition patterns

Fix typoed mention of config value using _ of -

981fddb

Clarify strlen_on_c_strings documentation (rust-lang#15711)

9aa3931

The original documentation had me confused for a couple of minutes. Now it should be more or less unambiguous. changelog: none

fix: implicit_saturating_sub suggests wrongly on untyped int literal

67a76f9

Fix redundant_pattern_matching misses ) in suggestion span (rust-…

b2670b4

…lang#16084) Closes rust-lang/rust-clippy#14989 changelog: [`redundant_pattern_matching`] fix missing `)` in suggestion span

Remove a single allocation on doc lints

ea3839a

Remove a single allocation on doc lints (rust-lang#16314)

bddcea7

Extremely small change, -0.018% performance improvement on `tokio` Just some warmup for continuing on larger optimizations (i.e. `nonminimal_bool`) changelog:Remove allocations via String pre-allocating.

remove another single allocation

a74de27

remove another single allocation (rust-lang#16315)

4a301a0

This removes another single allocation (namely by writing into an already existing `String` instead of allocating a new one just to `push_str` it). r? @blyxyas --- changelog: none

This comment has been minimized.

Sign in to view

Fix unnecessary_to_owned wrongly unmangled macros (rust-lang#16354)

500e0ff

Closes rust-lang/rust-clippy#16351 changelog: [`unnecessary_to_owned`] fix wrongly unmangled macros

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2026

This comment was marked as outdated.

Sign in to view

flip1995 and others added 3 commits January 9, 2026 10:37

Merge commit '500e0ff18726cd44b23004a02fc1b99f52c11ab1' into clippy-s…

d9c1685

…ubtree-update

Make Clippy compile with ConstArgKind::Tup()

a3690a2

Update Cargo.lock

d283798

flip1995 force-pushed the clippy-subtree-update branch from fc94dfc to d283798 Compare January 9, 2026 09:39

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

Further Clippy fixes for Tup/Literal ConstArgKind

330358a

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2026

rust-bors bot merged commit 1191620 into rust-lang:main Jan 10, 2026
12 checks passed

rustbot added this to the 1.94.0 milestone Jan 10, 2026

rust-bors bot mentioned this pull request Jan 10, 2026

mGCA: Support array expression as direct const arguments #150786

Merged

3 tasks

Uh oh!

Clippy subtree update #150818

Clippy subtree update #150818

Uh oh!

Conversation

flip1995 commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as off-topic.

This comment has been minimized.

samueltardieu commented Jan 9, 2026

Uh oh!

samueltardieu commented Jan 9, 2026

Uh oh!

samueltardieu commented Jan 9, 2026

Uh oh!

flip1995 commented Jan 9, 2026

Uh oh!

samueltardieu commented Jan 9, 2026

Uh oh!

rust-bors bot commented Jan 9, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 10, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 10, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jan 10, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants