-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Update libc to v0.2.180 #150752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update libc to v0.2.180 #150752
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
Mind waiting until tomorrow? I should have 0.2.180 out by then, which will include a handful of fixes on smaller targets (unbreaking uclibc) |
|
Sure, no problem. Should I close this PR or just update it when the release is there? |
|
You can leave it open, I'll ping once the release is out |
f581a0d to
a45ec88
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Wow you're on top of things, I was just about to ping here |
|
Just got an Email from the rustbot regarding the new libc release and updated the PR. |
library/std/Cargo.toml
Outdated
|
|
||
| [target.'cfg(not(all(windows, target_env = "msvc")))'.dependencies] | ||
| libc = { version = "0.2.178", default-features = false, features = [ | ||
| libc = { version = "0.2.179", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't actually using the very latest (0.2.180)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I did some errors locally with the git commands. Should be correct now.
a45ec88 to
47c5f58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM once CI passes
|
@bors r+ |
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
Rollup of 12 pull requests Successful merges: - #149961 (tidy: add if-installed prefix condition to extra checks system) - #150475 (std: sys: fs: uefi: Implement initial File) - #150533 (std: sys: fs: uefi: Implement remove_dir_all) - #150549 (fix missing_panics_doc in `std::os::fd::owned`) - #150699 (MGCA: Support literals as direct const arguments) - #150721 (Deprecated doc intra link) - #150752 (Update libc to v0.2.180) - #150802 (Minor cleanups to fn_abi_new_uncached) - #150803 (compiler-builtins subtree update) - #150809 (Update `literal-escaper` version to `0.0.7`) - #150811 (Store defids instead of symbol names in the aliases list) - #150825 (Query associated_item_def_ids when needed) r? @ghost
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
|
@bors try jobs=dist-ohos-x86_64 |
This comment has been minimized.
This comment has been minimized.
Update libc to v0.2.180 try-job: dist-ohos-x86_64
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
|
💔 Test for 607b25b failed: CI. Failed jobs:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
|
@bors r- |
|
Commit 47c5f58 has been unapproved. |
|
Hey, 2 things: First, it seems like the RTEMS target is actually compiling (my bad for the confusion as I'm the one who originally stated that the ambiguous export was blocking compilation for the vita). As I explained in this comment, when compiling rustc directly the lint is denied, but when using build-std it "just" shows a future-compat warning. You can also check the build history and the back-compat warning on does-it-build by noratrieb. Second, it seems like libc v0.2.179 broke ohos, I'm assuming due to rust-lang/libc#4463. Should we notify the ohos maintainers? |
|
Argh. It should probably be changed in libc, the fields need to get a Bit of a mess unfortunately, given the “similar but not identical” relationship between musl and ohos, and the lack of ohos testing. |
Follow-up of #150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.