Finish transition from semitransparent to semiopaque for rustc_macro_transparency
#150561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred in compiler/rustc_codegen_gcc |
rustbot
added
A-attributes
Collaborator
bjorn3
reviewed
Jan 1, 2026
lnicola
reviewed
Jan 1, 2026
This comment has been minimized.
This comment has been minimized.
hkBst
reviewed
Jan 3, 2026
Member
|
r? BoxyUwU @bors r+ rollup I assume the r-a side is fine since people have reviewed it :> it certainly doesn't seem egregiously wrong to me |
Collaborator
rust-bors
bot
added
S-waiting-on-bors
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
|
☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts. This pull request was unapproved. |
Collaborator
|
☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts. |
…acro_transparency`
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Trivial rebase. @bors r=BoxyUwU |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-author
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency` Since it's a bit annoying to have different names for the same thing. My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it. Continuation of - rust-lang#139084. Discovered while investigating - rust-lang#150514
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency` Since it's a bit annoying to have different names for the same thing. My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it. Continuation of - rust-lang#139084. Discovered while investigating - rust-lang#150514
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency` Since it's a bit annoying to have different names for the same thing. My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it. Continuation of - rust-lang#139084. Discovered while investigating - rust-lang#150514
rust-bors bot
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup of 11 pull requests Successful merges: - #150272 (docs(core): update `find()` and `rfind()` examples) - #150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - #150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - #150574 (Clarify `MoveData::init_loc_map`.) - #150762 (Use functions more in rustdoc GUI tests) - #150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - #150816 (Fix trait method anchor disappearing before user can click on it) - #150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - #150829 (make attrs actually use `Target::GenericParam`) - #150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - #150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup merge of #150561 - semiopaque, r=BoxyUwU Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency` Since it's a bit annoying to have different names for the same thing. My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it. Continuation of - #139084. Discovered while investigating - #150514
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 12, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#150272 (docs(core): update `find()` and `rfind()` examples) - rust-lang/rust#150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - rust-lang/rust#150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - rust-lang/rust#150574 (Clarify `MoveData::init_loc_map`.) - rust-lang/rust#150762 (Use functions more in rustdoc GUI tests) - rust-lang/rust#150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - rust-lang/rust#150816 (Fix trait method anchor disappearing before user can click on it) - rust-lang/rust#150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - rust-lang/rust#150829 (make attrs actually use `Target::GenericParam`) - rust-lang/rust#150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - rust-lang/rust#150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's a bit annoying to have different names for the same thing.
My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it.
Continuation of
Discovered while investigating
missing stability attributeerrors with trivial Externally Implementable Item (eii) function inlibrary/std#150514