Fix span note for question mark expression #149442
Open
+67
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
chenyukang
force-pushed
the
yukang-fix-mark-span-note-144304
branch
from
25479ea to
7a9e0df
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 4, 2025
…te-144304, r=estebank Fix span note for question mark expression Fixes rust-lang#144304 Seems it's better to fix the note instead of modifying the span to cover the whole expression. r? ``@estebank``
Member
bors
added
S-waiting-on-author
Member
|
Failed in rollup: #149628 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144304
Seems it's better to fix the note instead of modifying the span to cover the whole expression.
r? @estebank