-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Rollup of 6 pull requests #149419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #149419
Conversation
It is now part of the main workspace.
modules/mod_file_correct_spans.rs
modules/mod_file_disambig.rs add fix
typeck/qualified-path-params.rs merged test removed ui/qualified directory
…-timeout, r=Enselic Add a timeout to the `remote-test-client` connection Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example. This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached. Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds). This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI. Edit: ~~blocked by rust-lang#149071~~
Fix ICE when include_str! reads binary files ICE occurred when an invalid UTF8 file with an absolute path were included. resolve: rust-lang#149304
…gn-struct-fields, r=Kivooeo add regression test for issue rust-lang#143987 closes rust-lang#143987
Tidying up UI tests [5/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed prior to merge. part of rust-lang#133895 merge directory * `macro_backtrace` -> `macros` * `missing_non_modrs_mod` -> `modules` * `modules_and_files_visibility` -> `modules` * `qualified` -> `typeck` * `while` -> `for-loop-whlie` r? Kivooeo
…ted-closure-ice, r=JonathanBrouwer add test for issue 143821 closes rust-lang#143821
Remove test-float-parse from workspace list in tidy It is now part of the main workspace.
|
@bors r+ rollup=never p=5 |
Rollup of 6 pull requests Successful merges: - #147952 (Add a timeout to the `remote-test-client` connection) - #149321 (Fix ICE when include_str! reads binary files) - #149398 (add regression test for issue #143987) - #149411 (Tidying up UI tests [5/N]) - #149413 (add test for issue 143821) - #149415 (Remove test-float-parse from workspace list in tidy) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 9050733395 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 9050733 (parent) -> cc3eee7 (this PR) Test differencesShow 67 test diffsStage 0
Stage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cc3eee7fbe17ea4b7238531cb97e1b7b8bd6afce --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (cc3eee7): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 5.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.019s -> 472.717s (-0.06%) |
Successful merges:
remote-test-clientconnection #147952 (Add a timeout to theremote-test-clientconnection)passes_align_on_fields: #143987)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup