Extended temporary argument to format_args!() in all cases

[m-ou-se]

Fixes #145880 by removing the special case.

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred in coverage tests.

cc @Zalathar

[m-ou-se]

@bors try @rust-timer queue

[m-ou-se]

This should not be merged before #145838 is merged, to not make that problem worse.

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[rust-bors]

☀️ Try build successful (CI)
Build commit: a6a9c2f (a6a9c2fdb3e18f9e2288248b96b10108f7a262b0, parent: 4356e83c77cb28113411fb8e2219127f708095b5)

[rust-timer]

Finished benchmarking commit (a6a9c2f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	9
Regressions ❌ (secondary)	0.7%	[0.1%, 2.9%]	12
Improvements ✅ (primary)	-1.1%	[-1.7%, -0.7%]	5
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-0.2%	[-1.7%, 0.5%]	14

Max RSS (memory usage)

Results (primary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.4%, 4.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-3.9%, 4.0%]	3

Cycles

Results (secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[1.9%, 3.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	49
Regressions ❌ (secondary)	0.8%	[0.0%, 3.9%]	22
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	10
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	4
All ❌✅ (primary)	0.0%	[-0.3%, 0.3%]	59

Bootstrap: 468.126s -> 469.353s (0.26%)
Artifact size: 391.18 MiB -> 391.15 MiB (-0.01%)

[petrochenkov]

Blocked on #145838.
@rustbot blocked