Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc #144297

GuillaumeGomez · 2025-07-22T10:05:03Z

I think it's better to make this constant public so it can be used by crates using libtest as dependency.

As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.

rustbot · 2025-07-22T10:05:07Z

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GuillaumeGomez · 2025-07-22T10:05:31Z

Might be better to assign someone from the libs team instead.

r? @Amanieu

fbstj · 2025-07-22T10:15:54Z

library/test/src/lib.rs

@@ -90,7 +90,7 @@ use test_result::*;
 use time::TestExecTime;

 // Process exit code to be used to indicate test failures.


Suggested change

// Process exit code to be used to indicate test failures.

/// Process exit code to be used to indicate test failures.

GuillaumeGomez · 2025-07-22T11:30:07Z

Hum... I'll remove the change in librustdoc and make it as a follow-up since it seems it cannot be done in one PR. That's a bit sad.

Amanieu · 2025-07-25T10:53:41Z

This is fine since the entire libtest API is unstable.

@bors r+

bors · 2025-07-25T10:53:44Z

📌 Commit 3329c43 has been approved by Amanieu

It is now in the queue for this repository.

bors · 2025-07-30T22:34:15Z

☔ The latest upstream changes (presumably #144692) made this pull request unmergeable. Please resolve the merge conflicts.

…stdoc

GuillaumeGomez · 2025-07-31T09:53:01Z

@bors r=Amanieu rollup

bors · 2025-07-31T09:53:04Z

📌 Commit bee5fbf has been approved by Amanieu

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - #136840 (Fix linker-plugin-lto only doing thin lto) - #144053 (Remove install Rust script from CI) - #144297 (Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc) - #144721 (`std_detect`: Linux 6.16 support for RISC-V) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144297 - GuillaumeGomez:ERROR_EXIT_CODE, r=Amanieu Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc I think it's better to make this constant public so it can be used by crates using `libtest` as dependency. As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.

…Amanieu Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc I think it's better to make this constant public so it can be used by crates using `libtest` as dependency. As a side-note, I will update rust-lang#143900 to make use of this constant once this is current PR is merged.

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Rollup merge of #144739 - GuillaumeGomez:rustdoc-test-cleanup, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of #144297.

rustbot assigned notriddle Jul 22, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 22, 2025

rustbot assigned Amanieu and unassigned notriddle Jul 22, 2025

jieyouxu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 22, 2025

This comment has been minimized.

Sign in to view

fbstj reviewed Jul 22, 2025

View reviewed changes

GuillaumeGomez force-pushed the ERROR_EXIT_CODE branch from d9fe786 to 722e63a Compare July 22, 2025 11:17

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2025

GuillaumeGomez added 2 commits July 31, 2025 10:44

Make libtest::ERROR_EXIT_CODE const public to not redefine it in ru…

227abb7

…stdoc

Fix CI build failure when using new libtest public constant

bee5fbf

GuillaumeGomez force-pushed the ERROR_EXIT_CODE branch from 3329c43 to bee5fbf Compare July 31, 2025 08:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025

samueltardieu mentioned this pull request Jul 31, 2025

Rollup of 4 pull requests #144731

Merged

bors merged commit febd8cd into rust-lang:master Jul 31, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jul 31, 2025

GuillaumeGomez deleted the ERROR_EXIT_CODE branch July 31, 2025 15:13

GuillaumeGomez mentioned this pull request Jul 31, 2025

Use new public libtest ERROR_EXIT_CODE constant in rustdoc #144739

Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

f7eaf6a

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

427d004

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

edd8735

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

f46214b

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

a10e87c

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

d9c745c

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

02c12e2

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

ac09d9e

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025

Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…

3d6976c

…p, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of rust-lang#144297.

rust-timer added a commit that referenced this pull request Aug 10, 2025

Unrolled build for #144739

077bc8e

Rollup merge of #144739 - GuillaumeGomez:rustdoc-test-cleanup, r=fmease Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc Followup of #144297.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc #144297

Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc #144297

Uh oh!

GuillaumeGomez commented Jul 22, 2025

Uh oh!

rustbot commented Jul 22, 2025

Uh oh!

GuillaumeGomez commented Jul 22, 2025

Uh oh!

This comment has been minimized.

fbstj Jul 22, 2025

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jul 22, 2025

Uh oh!

Amanieu commented Jul 25, 2025

Uh oh!

bors commented Jul 25, 2025

Uh oh!

bors commented Jul 30, 2025

Uh oh!

GuillaumeGomez commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -90,7 +90,7 @@ use test_result::*;
		use time::TestExecTime;

		// Process exit code to be used to indicate test failures.

	// Process exit code to be used to indicate test failures.
	/// Process exit code to be used to indicate test failures.

Make libtest::ERROR_EXIT_CODE const public to not redefine it in rustdoc #144297

Make libtest::ERROR_EXIT_CODE const public to not redefine it in rustdoc #144297

Uh oh!

Conversation

GuillaumeGomez commented Jul 22, 2025

Uh oh!

rustbot commented Jul 22, 2025

Uh oh!

GuillaumeGomez commented Jul 22, 2025

Uh oh!

This comment has been minimized.

fbstj Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jul 22, 2025

Uh oh!

Amanieu commented Jul 25, 2025

Uh oh!

bors commented Jul 25, 2025

Uh oh!

bors commented Jul 30, 2025

Uh oh!

GuillaumeGomez commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc #144297

Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc #144297