Skip to content

tidy: use --bless for tidy spellcheck instead of spellcheck:fix #143493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

tidy: use --bless for tidy spellcheck instead of spellcheck:fix #143493

merged 3 commits into from
Jul 6, 2025

Conversation

lolbinarycat
Copy link
Contributor

previous behavior was inconsistent with existing extra checks.

unsure if this needs a change tracker entry or a warning for people who try to use the old behavior.

unsure if we should call this spellcheck:lint for consistency.

making this consistent is a prerequisite for #143398

cc @nnethercote

r? @Kobzol

@lolbinarycat
tidy: use --bless for tidy spellcheck instead of spellcheck:fix
971feb6 
previous behavior was inconsistent with existing extra checks.
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2025

There are changes to the tidy tool.

cc @jieyouxu

Kobzol
Kobzol reviewed Jul 5, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks! Yes, please include a Warning change tracker entry, even though I suspect not many people use this. You can r=me after that (and green CI).

@klensy
Copy link
Contributor

klensy commented Jul 5, 2025 •
edited
Loading

Why spellcheck:fix should use --bless but not py:fmt, cpp:fmt? This options all mutate files.

Ahh, my bad, found bless in py:fmt and cpp:fmt.

Kobzol
Kobzol reviewed Jul 5, 2025
View reviewed changes
@klensy
Copy link
Contributor

klensy commented Jul 5, 2025

And need to regenerate completions after #143452.

@Kobzol
Copy link
Member

Kobzol commented Jul 5, 2025

There should be no need for that, as the documentation of Clap flags (and thus CLI help output) wasn't changed.

@lolbinarycat
Copy link
Contributor Author

lolbinarycat commented Jul 5, 2025 •
edited
Loading

@Kobzol done, want me to squash the last 2 together?

Update: squashed it anyways, it makes more sense that way I think.

@lolbinarycat lolbinarycat force-pushed the tidy-spellcheck-bless branch from 1ab0518 to 9f78173 Compare July 5, 2025 20:24
@Kobzol
Copy link
Member

Kobzol commented Jul 5, 2025

Thanks! You can r=me once CI is green.

@lolbinarycat
Copy link
Contributor Author

@Kobzol i don't have bors perms yet, do you want to delegate the pr?

@Kobzol
Copy link
Member

Kobzol commented Jul 5, 2025

Ooh, I see, sorry! Here you go :)

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

@lolbinarycat
Copy link
Contributor Author

@bors r=@Kobzol

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

📌 Commit 9f78173 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 6, 2025
Merged
bors added a commit that referenced this pull request Jul 6, 2025
@bors
Auto merge of #143521 - matthiaskrgr:rollup-kpv1og3, r=matthiaskrgr
c83e217 
Rollup of 6 pull requests

Successful merges:

 - #143416 (mbe: Defer checks for `compile_error!` until reporting an unused macro rule)
 - #143470 (std: sys: net: uefi: tcp4: Implement read)
 - #143477 (use `is_multiple_of` and `div_ceil`)
 - #143484 (distinguish the duplicate item of rpitit)
 - #143493 (tidy: use --bless for tidy spellcheck instead of spellcheck:fix)
 - #143504 (compiletest: print slightly more information on fs::write failure)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e25654f into rust-lang:master Jul 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 6, 2025
rust-timer added a commit that referenced this pull request Jul 6, 2025
@rust-timer
Unrolled build for #143493
6a3316f 
Rollup merge of #143493 - lolbinarycat:tidy-spellcheck-bless, r=Kobzol

tidy: use --bless for tidy spellcheck instead of spellcheck:fix

previous behavior was inconsistent with existing extra checks.

unsure if this needs a change tracker entry or a warning for people who try to use the old behavior.

unsure if we should call this `spellcheck:lint` for consistency.

making this consistent is a prerequisite for #143398

cc `@nnethercote`

r? `@Kobzol`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lolbinarycat @rustbot @klensy @Kobzol @bors