Skip to content

Use the correct export kind for __rust_alloc_error_handler_should_panic #143260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use the correct export kind for __rust_alloc_error_handler_should_panic #143260

wants to merge 1 commit into from

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Jun 30, 2025 •
edited by rustbot
Loading

Fixes #143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@dpaoliello dpaoliello mentioned this pull request Jun 30, 2025
Closed
@bjorn3
Copy link
Member

bjorn3 commented Jul 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

📌 Commit c073286 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 1, 2025
@jhpratt
Rollup merge of rust-lang#143260 - dpaoliello:arm64eclinkagain, r=bjorn3
932d198 
Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.

Fix is to export the symbol as data.

r? `@bjorn3`
@jhpratt jhpratt mentioned this pull request Jul 1, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143305 - jhpratt:rollup-t7e7uhj, r=jhpratt
5264bc9 
Rollup of 12 pull requests

Successful merges:

 - #141829 (Specialize sleep_until implementation for unix (except mac))
 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142568 (Use the .drectve section for exporting symbols from dlls on Windows)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#143260 - dpaoliello:arm64eclinkagain, r=bjorn3
17cc26e 
Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.

Fix is to export the symbol as data.

r? ``@bjorn3``
@jhpratt jhpratt mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143311 - jhpratt:rollup-vjx4zoy, r=jhpratt
77b41b0 
Rollup of 11 pull requests

Successful merges:

 - #141829 (Specialize sleep_until implementation for unix (except mac))
 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#143260 - dpaoliello:arm64eclinkagain, r=bjorn3
aeffc8e 
Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.

Fix is to export the symbol as data.

r? ```@bjorn3```
@jhpratt jhpratt mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143313 - jhpratt:rollup-55h4nj0, r=jhpratt
4d9342a 
Rollup of 12 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#143260 - dpaoliello:arm64eclinkagain, r=bjorn3
5719019 
Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.

Fix is to export the symbol as data.

r? ````@bjorn3````
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143317 - matthiaskrgr:rollup-isq1wbb, r=matthiaskrgr
28c341e 
Rollup of 11 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#143260 - dpaoliello:arm64eclinkagain, r=bjorn3
d7fbef4 
Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.

Fix is to export the symbol as data.

r? `````@bjorn3`````
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143322 - matthiaskrgr:rollup-h6xw7i5, r=matthiaskrgr
58dd450 
Rollup of 10 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#143322 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 2, 2025
@dpaoliello
Copy link
Contributor Author

I'm going to switch approaches and convert __rust_alloc_error_handler_should_panic to be a function instead.

@dpaoliello dpaoliello closed this Jul 2, 2025
@dpaoliello dpaoliello deleted the arm64eclinkagain branch August 5, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linking broken on arm64ec due to __rust_alloc_error_handler_should_panic symbol
5 participants
@dpaoliello @rustbot @bjorn3 @bors @matthiaskrgr