Skip to content

GCI: Imply outlives-bounds on free (generic) const items #143029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 25, 2025

Part of #113521.

@fmease fmease added the F-generic_const_items `#![feature(generic_const_items)]` label Jun 25, 2025
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2025
@fmease fmease moved this to In Progress in Generic Const Items (GCI) Jun 25, 2025
@fmease
Copy link
Member Author

fmease commented Jun 25, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jun 25, 2025
GCI: Imply outlives-bounds on free (generic) const items
@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

⌛ Trying commit 5aa3d2a with merge eb427c5

To cancel the try build, run the command @bors2 try cancel.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

☀️ Try build successful (CI)
Build commit: eb427c5 (eb427c5414bee321329c635f289f46816100d758, parent: d14d202262d13df896b0c624b0cec6e4bfde631a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eb427c5): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 689.033s -> 689.561s (0.08%)
Artifact size: 372.09 MiB -> 372.11 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 27, 2025
@fmease
Copy link
Member Author

fmease commented Jun 27, 2025

(All of these failures are cycle errors that now occur when we try to recover from the user using _ in / omitting the type of consts, this "niceness" really is the bane of my existence)

@fmease
Copy link
Member Author

fmease commented Jun 27, 2025

@bors2 try parent=last @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jun 27, 2025

⌛ Trying commit c2b8a0b with merge 25444d3

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 27, 2025
GCI: Imply outlives-bounds on free (generic) const items

Part of #113521.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 27, 2025
@fmease fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Jun 27, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 27, 2025

☀️ Try build successful (CI)
Build commit: 25444d3 (25444d3ddb1285d7ea04f0b89fdf4318a474d5df, parent: d14d202262d13df896b0c624b0cec6e4bfde631a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (25444d3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.5%, 2.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 689.033s -> 690.033s (0.15%)
Artifact size: 372.09 MiB -> 372.08 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2025
@rustbot rustbot removed the perf-regression Performance regression. label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide F-generic_const_items `#![feature(generic_const_items)]` rla-silenced Silences rust-log-analyzer postings to the PR it's added on. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants